Fix NetMHCstabpan mixed-length peptides - #256
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #253.
NetMHCstabpan no longer rejects mixed-length peptide inputs in
predict_peptides. The wrapper now opts into the existingBaseCommandlinePredictorlength-grouping path, matching the behavior already used by other command-line predictors that require same-length batches.Impact
Callers can pass mixed 8/9/10-mer peptide lists directly to
NetMHCstabpan.predict_peptidesandpredict_peptides_dataframe; mhctools groups the temporary input files by peptide length before invoking the external predictor.Validation
pytest tests/test_netmhc_stabpan.py::test_netmhc_stabpan_groups_mixed_length_peptides -q./lint.sh./test.sh(637 passed, 51 skipped, 2 xfailed)Version
Bumped package version from
3.31.0to3.31.1.